Prevent concurrent ::export() calls in span processor#788
Merged
brettmc merged 6 commits intoAug 24, 2022
Conversation
Codecov Report
@@ Coverage Diff @@
## main #788 +/- ##
============================================
+ Coverage 80.40% 80.66% +0.25%
- Complexity 1765 1786 +21
============================================
Files 222 222
Lines 4516 4592 +76
============================================
+ Hits 3631 3704 +73
- Misses 885 888 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Nevay
force-pushed
the
fix/prevent-concurrent-exports
branch
from
August 4, 2022 17:42
77e02fc to
af668ad
Compare
Nevay
commented
Aug 4, 2022
| int $scheduledDelayMillis = self::DEFAULT_SCHEDULE_DELAY, | ||
| int $exportTimeoutMillis = self::DEFAULT_EXPORT_TIMEOUT, | ||
| int $maxExportBatchSize = self::DEFAULT_MAX_EXPORT_BATCH_SIZE, | ||
| bool $autoFlush = true |
Contributor
Author
There was a problem hiding this comment.
Should be changed to default false before beta to be consistent with async implementations that will only export once the event loop gains control. Using default true for now to keep the scope of the PR small / to not break examples etc.
Nevay
marked this pull request as ready for review
August 4, 2022 20:53
Nevay
requested review from
bobstrecansky,
brettmc,
tidal and
zsistla
as code owners
August 4, 2022 20:53
brettmc
reviewed
Aug 5, 2022
Nevay
force-pushed
the
fix/prevent-concurrent-exports
branch
from
August 10, 2022 15:00
de53b81 to
4a2b869
Compare
brettmc
reviewed
Aug 17, 2022
Nevay
force-pushed
the
fix/prevent-concurrent-exports
branch
from
August 17, 2022 20:10
88e0a69 to
d309f83
Compare
brettmc
approved these changes
Aug 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR calls
::export()in a synchronous loop to prevent concurrent calls to::export().Note that this might block the
Span::end()call that triggered the export longer. The blocking autoflush behavior ofBatchSpanProcessor::onEnd()can be disabled, spans will then only be flushed on explicit::forceFlush()/::shutdown()calls.Disallowing concurrent export calls means that we have to reintroduce support for concurrent exports by changing the return type of
::export()to a promise/future-like value - I plan on working on that after this PR is merged.Alternative to #787, see also #787 (comment).