Codecov Report

Merging #784 (d0b6e49) into main (bf912ed) will increase coverage by 0.10%.
The diff coverage is 100.00%.

❗ Current head d0b6e49 differs from pull request most recent head 22be517. Consider uploading reports for the commit 22be517 to get more accurate results

@@             Coverage Diff              @@
##               main     #784      +/-   ##
============================================
+ Coverage     79.37%   79.48%   +0.10%     
+ Complexity     1407     1406       -1     
============================================
  Files           160      160              
  Lines          3477     3470       -7     
============================================
- Hits           2760     2758       -2     
+ Misses          717      712       -5     

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf912ed...22be517. Read the comment docs.

Another failing test:

$generator = (fn() => yield from [1, 2])();
$generator->next();
assert(!isEmpty($generator));

$generator = (fn() => yield from [1, 2])();
$generator->next();
assert(!isEmpty($generator));

This is a non empty generator case and hence isEmpty() will return false. Hence the test case is passing

isEmpty() will return false

Currently it returns true (foreach tries to rewind the generator and triggers an exception).

What is the expected result for an exhausted rewindable iterator?

$iterator = new ArrayIterator([1]);
$iterator->next();
$empty = isEmpty($iterator); // ?

Should isEmpty() be allowed to modify the given iterable (somewhat obsolete if we mark the function as internal)?

$iterator = new ArrayIterator([1, 2]);
$iterator->next();
isEmpty($iterator);
$value = $iterator->current(); // ?

Side note: We could simply remove the special handling of an empty batch and the isEmpty() function, our span processors call SpanExporter::export() with a non-empty batch / exporters can skip empty exports after conversion.

Makes sense. The iterable will be modified.