Skip to content

Use of "iterable" Type May Need Re-Evaluation Across the Repo#783

Merged
bobstrecansky merged 14 commits into
open-telemetry:mainfrom
amber0612:main
Jul 20, 2022
Merged

Use of "iterable" Type May Need Re-Evaluation Across the Repo#783
bobstrecansky merged 14 commits into
open-telemetry:mainfrom
amber0612:main

Conversation

@amber0612

Copy link
Copy Markdown
Contributor

@codecov

codecov Bot commented Jul 20, 2022

Copy link
Copy Markdown

Codecov Report

Merging #783 (d0b2dc5) into main (08c9180) will decrease coverage by 0.11%.
The diff coverage is 28.57%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #783      +/-   ##
============================================
- Coverage     79.49%   79.37%   -0.12%     
  Complexity     1407     1407              
============================================
  Files           160      160              
  Lines          3472     3477       +5     
============================================
  Hits           2760     2760              
- Misses          712      717       +5     
Flag Coverage Δ
7.4 79.38% <28.57%> (-0.12%) ⬇️
8.0 79.44% <28.57%> (-0.12%) ⬇️
8.1 79.44% <28.57%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SDK/Common/Util/functions.php 76.19% <0.00%> (-23.81%) ⬇️
src/SDK/Metrics/Exporters/AbstractExporter.php 75.00% <100.00%> (ø)
src/SDK/Trace/Behavior/SpanExporterTrait.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08c9180...d0b2dc5. Read the comment docs.

@amber0612
amber0612 marked this pull request as ready for review July 20, 2022 09:39
@bobstrecansky
bobstrecansky merged commit bf912ed into open-telemetry:main Jul 20, 2022
@bobstrecansky

Copy link
Copy Markdown
Contributor

@amber0612 mentioned a subsequent PR that will fill in some iterable gaps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants