Remove null default value from parameters that are never null#779
Merged
brettmc merged 3 commits intoAug 1, 2022
Merged
Conversation
Not needed / resetting is inconsistent with other span builder values.
Nevay
requested review from
bobstrecansky,
brettmc,
tidal and
zsistla
as code owners
July 18, 2022 15:24
Codecov Report
@@ Coverage Diff @@
## main #779 +/- ##
============================================
+ Coverage 79.53% 79.64% +0.11%
+ Complexity 1409 1394 -15
============================================
Files 160 160
Lines 3479 3469 -10
============================================
- Hits 2767 2763 -4
+ Misses 712 706 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
brettmc
approved these changes
Jul 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents having to handle
nullvalues for parameters that will never be null. Might simplifiy user implementations and removes ambiguity if the meaning ofnullis not obvious.