Skip to content

logging more errors#764

Merged
bobstrecansky merged 1 commit into
open-telemetry:mainfrom
brettmc:logging-more-errors
Jul 13, 2022
Merged

logging more errors#764
bobstrecansky merged 1 commit into
open-telemetry:mainfrom
brettmc:logging-more-errors

Conversation

@brettmc

@brettmc brettmc commented Jul 13, 2022

Copy link
Copy Markdown
Contributor

Adding some more logging, to address #298

@codecov

codecov Bot commented Jul 13, 2022

Copy link
Copy Markdown

Codecov Report

Merging #764 (d282314) into main (f33b623) will decrease coverage by 3.27%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #764      +/-   ##
============================================
- Coverage     82.86%   79.59%   -3.28%     
  Complexity     1295     1295              
============================================
  Files           150      150              
  Lines          3192     3195       +3     
============================================
- Hits           2645     2543     -102     
- Misses          547      652     +105     
Flag Coverage Δ
7.4 79.57% <71.42%> (-3.30%) ⬇️
8.0 79.64% <71.42%> (-3.28%) ⬇️
8.1 79.64% <71.42%> (-3.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Contrib/Jaeger/JaegerTransport.php 86.66% <0.00%> (ø)
src/SDK/Trace/Behavior/HttpSpanExporterTrait.php 93.47% <66.66%> (-1.88%) ⬇️
src/SDK/Trace/TracerProviderFactory.php 100.00% <100.00%> (ø)
src/SDK/Trace/Span.php 12.50% <0.00%> (-81.74%) ⬇️
src/SDK/Trace/SpanLimits.php 0.00% <0.00%> (-75.00%) ⬇️
src/API/Trace/AbstractSpan.php 0.00% <0.00%> (-38.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f33b623...d282314. Read the comment docs.

@bobstrecansky
bobstrecansky merged commit 37a8c8e into open-telemetry:main Jul 13, 2022
@brettmc
brettmc deleted the logging-more-errors branch October 25, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants