Invalid @covers annotations in SpanTest create warning in PHPunit runs#752
Merged
Conversation
amber0612
requested review from
bobstrecansky,
brettmc,
tidal and
zsistla
as code owners
July 6, 2022 11:22
Codecov Report
@@ Coverage Diff @@
## main #752 +/- ##
============================================
- Coverage 82.86% 79.60% -3.26%
Complexity 1295 1295
============================================
Files 150 150
Lines 3192 3192
============================================
- Hits 2645 2541 -104
- Misses 547 651 +104
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
amber0612
marked this pull request as draft
July 6, 2022 11:30
brettmc
reviewed
Jul 6, 2022
Contributor
|
Reran these tests after the fix; looks better now. |
amber0612
marked this pull request as ready for review
July 7, 2022 05:51
Contributor
|
I think the only thing left on this PR is @brettmc 's comments. |
brettmc
approved these changes
Jul 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#732