Add metrics implementation#750
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #750 +/- ##
============================================
+ Coverage 78.43% 79.56% +1.13%
- Complexity 1331 1679 +348
============================================
Files 153 213 +60
Lines 3278 4296 +1018
============================================
+ Hits 2571 3418 +847
- Misses 707 878 +171
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
brettmc
reviewed
Jul 6, 2022
brettmc
left a comment
brettmc
left a comment
Contributor
There was a problem hiding this comment.
Initial review done, this looks great. I need to go over the spec in more detail, but so far this seems to be following the spec very closely.
To be discussed: naming of interfaces :)
Nevay
force-pushed
the
feature/metrics-sdk
branch
from
July 8, 2022 22:43
2e6f4ff to
2659b9d
Compare
Nevay
commented
Jul 10, 2022
Nevay
marked this pull request as ready for review
July 11, 2022 14:02
brettmc
reviewed
Jul 13, 2022
|
|
||
| namespace OpenTelemetry\SDK\Metrics; | ||
|
|
||
| interface DefaultAggregationProvider |
Contributor
There was a problem hiding this comment.
Suggested change
| interface DefaultAggregationProvider | |
| interface DefaultAggregationProviderInterface |
Contributor
|
I think I've reviewed this as well as I can. I'm happy to approve, and then it can get some real-world testing. Perhaps a first step might be to create an example that exports to the otel collector (when we do have a metrics exporter, I'm not sure that we do yet) |
brettmc
reviewed
Jul 13, 2022
| if ($response->getStatusCode() >= 400 && $response->getStatusCode() < 500 && $response->getStatusCode() !== 408) { | ||
| return false; | ||
| } | ||
| } catch (RequestExceptionInterface $e) { |
Contributor
There was a problem hiding this comment.
good spot to log an error or warning, as we get close to beta
Allows removing view registry dependency from `MetricFactory`. Should ideally turn of staleness handling for asynchronous instruments with permanently registered callbacks (drop all `::onStale()` callbacks and prevent addition of new callbacks).
Was mainly a side-effect of using `spl_object_id()`; lead to inconsistent behavior between providing same and identical callbacks; reverting back to incrementing index, keyspace is large enough.
- move default aggregation handling to metric reader / metric exporter - move view registration to meter provider constructor - move exemplar reservoir creation to aggregation to support user implementations - remove `AttributeProcessor` from view as baggage access was dropped from spec - deduplicate metric streams
- add missing `Interface` suffix - move callback destructors to metric observer to not detach if meter and meter provider are out of scope - simplify `::viewRegistrationRequests()` by readding fallback view
- rename `MetricObserver::weakMap()` to `::destructors()` to better reflect usage` - move `ReferenceCounter::acquire()` call to corresponding `MetricObserver::observe()` call for consistency - cache instrumentation scope id in `Meter` to avoid repeated calls to `serialize()` - remove obsolete instrument type check from `ViewProjection`, leftover from supporting aggregation per type
Nevay
force-pushed
the
feature/metrics-sdk
branch
from
July 16, 2022 09:23
3dd549e to
5c99ad0
Compare
…kMap` key going out of scope
bobstrecansky
approved these changes
Aug 10, 2022
This was referenced Aug 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the current implementation as it does not conform to the (current version of) the spec.
See
examples/metrics/basic.phpon how to use/create a meter provider.(Incomplete) todo list:
_bridge.php