Refactor TraceState's __toString method #727 Span Attributes Documentation#704#729
Merged
Conversation
amber0612
requested review from
bobstrecansky,
brettmc,
tidal and
zsistla
as code owners
June 25, 2022 06:50
Codecov Report
@@ Coverage Diff @@
## main #729 +/- ##
============================================
- Coverage 82.65% 82.63% -0.02%
- Complexity 1271 1272 +1
============================================
Files 145 145
Lines 3124 3121 -3
============================================
- Hits 2582 2579 -3
Misses 542 542
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
amber0612
changed the title
amber0612
marked this pull request as draft
June 27, 2022 13:32
amber0612
marked this pull request as ready for review
June 28, 2022 06:26
bobstrecansky
approved these changes
Jun 29, 2022
This was
linked to
issues
Jun 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#727
#704