Add basic InstrumentationInterface and InstrumentationTrait#726
Merged
Conversation
tidal
force-pushed
the
instrumentation
branch
2 times, most recently
from
June 23, 2022 18:17
957f11d to
8d0dc43
Compare
Codecov Report
@@ Coverage Diff @@
## main #726 +/- ##
============================================
+ Coverage 82.37% 82.65% +0.27%
- Complexity 1249 1271 +22
============================================
Files 140 145 +5
Lines 3052 3124 +72
============================================
+ Hits 2514 2582 +68
- Misses 538 542 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
brettmc
approved these changes
Jun 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an InstrumentationInterface and InstrumentationTrait which are meant as a base for (contrib) instrumentations.
(Registering/Activating the Instrumentation with the API has yet to be implemted)