Make AttributesInterface immutable#724
Merged
Merged
Conversation
- remove not required methods - rename `::hasAttribute()` to `::has()` for consistency with `::get()`
Mainly useful for metrics sdk that has to rebuild filtered attributes.
Codecov Report
@@ Coverage Diff @@
## main #724 +/- ##
============================================
- Coverage 82.41% 82.37% -0.05%
- Complexity 1247 1249 +2
============================================
Files 139 140 +1
Lines 3048 3052 +4
============================================
+ Hits 2512 2514 +2
- Misses 536 538 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Nevay
marked this pull request as ready for review
June 22, 2022 17:56
Nevay
requested review from
bobstrecansky,
brettmc,
tidal and
zsistla
as code owners
June 22, 2022 17:56
brettmc
approved these changes
Jun 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
AttributesInterfaceimmutable by introducingAttributesBuilderInterfaceas mutable builder.Resolves #709, see also #542.