Prevent leaking TracerProvider in register_shutdown_function()#716
Merged
brettmc merged 1 commit intoJun 21, 2022
Merged
Conversation
Nevay
requested review from
bobstrecansky,
brettmc,
tidal and
zsistla
as code owners
June 17, 2022 20:48
Codecov Report
@@ Coverage Diff @@
## main #716 +/- ##
============================================
- Coverage 82.78% 82.41% -0.38%
- Complexity 1241 1247 +6
============================================
Files 139 139
Lines 3033 3048 +15
============================================
+ Hits 2511 2512 +1
- Misses 522 536 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Nevay
force-pushed
the
fix/tracer-register-shutdown-function-leaks-memory
branch
from
June 17, 2022 22:11
c0bca40 to
6d66e0e
Compare
brettmc
approved these changes
Jun 18, 2022
brettmc
approved these changes
Jun 21, 2022
This was referenced Jul 6, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix memory leak caused by keeping strong references to every created
TracerProviderin callback provided toregister_shutdown_function().