Cleanup/fix context package#711
Merged
bobstrecansky merged 14 commits intoJun 16, 2022
Merged
Conversation
Creates a hidden `Scope` when called without `$parent`.
Resolves inconsistencies in case-insensitive handling.
Nevay
requested review from
bobstrecansky,
brettmc,
tidal and
zsistla
as code owners
June 15, 2022 20:12
Codecov Report
@@ Coverage Diff @@
## main #711 +/- ##
============================================
- Coverage 83.82% 82.78% -1.04%
- Complexity 1233 1241 +8
============================================
Files 138 139 +1
Lines 2980 3033 +53
============================================
+ Hits 2498 2511 +13
- Misses 482 522 +40
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Revert after introducing ContextInterface?
brettmc
reviewed
Jun 16, 2022
brettmc
reviewed
Jun 16, 2022
brettmc
approved these changes
Jun 16, 2022
bobstrecansky
approved these changes
Jun 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed:
Context::withValue(): Semi-broken due to creation of hidden scopeContext::detach(): Same functionality asScopeInterface::detach()Context::attach(): Same functionality asContext::activate()Context::getValue(): Can be removed? Users will use class-specific::fromContext()/::getCurrrent()methods instead of this method anyways?Changes:
ContextandContextKey: Changed tofinalto reduce scope / allow addition of new methods in the future without breaking backwards compatibility.ArrayAccessGetterSetter: Resolves issues with case-insensitive keys and preserves casing as recommended by spec.