You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current symfony quickstart goes through the whole process of creating a symfony application while completely missing to use best practices when adding tracing. I believe it's unlikely that a complete symfony novice would be looking up a quickstart like this, making it quite unnecessary in my opinion.
At the same time, the SDK bundle already has a readme explaining how to add tracing to your symfony application. Also using a bundle is the best practice and is what 99% of symfony users will want to do.
This is why I propose to ditch the quickstart and instead link to the SDK bundle in the readme, and put all future symfony-specific documentation there.
Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.
Just for the record, your CLA signing process is extremely frustrating and I don't wish to submit any of my personal details like my signature or home address to you. Also it's missing a privacy statement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current symfony quickstart goes through the whole process of creating a symfony application while completely missing to use best practices when adding tracing. I believe it's unlikely that a complete symfony novice would be looking up a quickstart like this, making it quite unnecessary in my opinion.
At the same time, the SDK bundle already has a readme explaining how to add tracing to your symfony application. Also using a bundle is the best practice and is what 99% of symfony users will want to do.
This is why I propose to ditch the quickstart and instead link to the SDK bundle in the readme, and put all future symfony-specific documentation there.