Prevent creation of invalid trace id / span id in RandomIdGenerator#699
Merged
brettmc merged 1 commit intoJun 6, 2022
Merged
Conversation
Nevay
requested review from
bobstrecansky,
brettmc,
tidal and
zsistla
as code owners
June 3, 2022 17:13
Codecov Report
@@ Coverage Diff @@
## main #699 +/- ##
============================================
+ Coverage 83.82% 83.84% +0.02%
Complexity 1233 1233
============================================
Files 138 138
Lines 2980 2984 +4
============================================
+ Hits 2498 2502 +4
Misses 482 482
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kishannsangani
approved these changes
Jun 3, 2022
brettmc
approved these changes
Jun 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.