Codecov Report

Merging #696 (d88263b) into main (90edbd3) will not change coverage.
The diff coverage is n/a.

❗ Current head d88263b differs from pull request most recent head 3534f3d. Consider uploading reports for the commit 3534f3d to get more accurate results

@@            Coverage Diff            @@
##               main     #696   +/-   ##
=========================================
  Coverage     82.77%   82.77%           
  Complexity     1242     1242           
=========================================
  Files           139      139           
  Lines          3036     3036           
=========================================
  Hits           2513     2513           
  Misses          523      523           

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90edbd3...3534f3d. Read the comment docs.

This is still patching the front controller and using global states (which is the opposite of best practices)

@tidal For HelloController in both Laravel and Symfony, we have used TracerProvider::getDefaultTracer() to get default tracer and AbstractSpan::getCurrent() to get current span, i.e. rootSpan. However, in Symfony, there is a change in index.php. Unlike Laravel which calls the kernel terminate function in the index.php itself, Symfony index.php returns a function that returns kernel based on the context provided. We should end span only after kernel terminate is called but I couldn't trace where it is called. So I placed the end span snippet in the kernel terminate function itself that uses global variables. I can use AbstractSpan::getCurrent() to get the current span but I cannot get the current scope via that function. Can you help me out with this?

@tidal Can you help me resolve this PR? What should I do w.r.t. this PR?

As discussed in the SIG meeting today, incorporated changes from PR by DrLuke into this PR.