Add the base docker image to w3c context validation tests#673
Merged
Conversation
Use the base docker image in the docker-compose file of the W3C context validation tests to speed up the test set up
Codecov Report
@@ Coverage Diff @@
## main #673 +/- ##
============================================
+ Coverage 85.26% 85.28% +0.02%
+ Complexity 1153 1151 -2
============================================
Files 128 128
Lines 2789 2794 +5
============================================
+ Hits 2378 2383 +5
Misses 411 411
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
yuktea
marked this pull request as ready for review
May 6, 2022 22:34
yuktea
requested review from
bobstrecansky,
brettmc,
tidal and
zsistla
as code owners
May 6, 2022 22:34
brettmc
approved these changes
May 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To speed up the test setup, the base docker image is put to use in the docker-compose file for
W3C trace-context validation tests.A part of Issue #589