Add phpunit annotations for compliance tests#670
Merged
Conversation
yuktea
force-pushed
the
phpunit-annotations
branch
from
May 5, 2022 10:58
d578745 to
df2b017
Compare
Had to re-run `make style`, somehow missed a spot.
yuktea
force-pushed
the
phpunit-annotations
branch
from
May 6, 2022 21:42
df2b017 to
fee9b01
Compare
Codecov Report
@@ Coverage Diff @@
## main #670 +/- ##
============================================
+ Coverage 85.28% 86.07% +0.78%
Complexity 1151 1151
============================================
Files 128 128
Lines 2794 2794
============================================
+ Hits 2383 2405 +22
+ Misses 411 389 -22
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
yuktea
marked this pull request as ready for review
May 6, 2022 21:45
yuktea
requested review from
bobstrecansky,
brettmc,
tidal and
zsistla
as code owners
May 6, 2022 21:45
Contributor
Author
|
Rebased and good to go! |
brettmc
approved these changes
May 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible spec matrix changes:
Associate Tracer with InstrumentationScopeDefault value for service.name