Refactored ResourceInfo and ResourceInfoFactory Unit and Integration tests#664
Merged
bobstrecansky merged 1 commit intoApr 20, 2022
Conversation
kishannsangani
requested review from
bobstrecansky,
brettmc,
tidal and
zsistla
as code owners
April 20, 2022 09:46
Codecov Report
@@ Coverage Diff @@
## main #664 +/- ##
============================================
+ Coverage 84.28% 85.25% +0.96%
Complexity 1153 1153
============================================
Files 128 128
Lines 2788 2788
============================================
+ Hits 2350 2377 +27
+ Misses 438 411 -27
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
brettmc
approved these changes
Apr 20, 2022
bobstrecansky
approved these changes
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved test functions belonging to ResourceInfoFactory out from ResourceInfoTest and moved some tests out from Unit test to Integration test.
Closes #629.