Add integration tests for tracing compliance#662
Merged
Conversation
yuktea
requested review from
bobstrecansky,
brettmc,
tidal and
zsistla
as code owners
April 14, 2022 16:12
yuktea
marked this pull request as draft
April 14, 2022 16:15
yuktea
marked this pull request as ready for review
April 14, 2022 16:26
Codecov Report
@@ Coverage Diff @@
## main #662 +/- ##
============================================
- Coverage 84.45% 84.28% -0.17%
- Complexity 1141 1153 +12
============================================
Files 127 128 +1
Lines 2766 2788 +22
============================================
+ Hits 2336 2350 +14
- Misses 430 438 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
bobstrecansky
approved these changes
Apr 14, 2022
brettmc
reviewed
Apr 14, 2022
brettmc
reviewed
Apr 14, 2022
brettmc
reviewed
Apr 14, 2022
Contributor
|
any tests which are verifying behaviour from the spec compliance matrix need a group annotation, please |
Modified the names of the tests to be more descriptive and added the `@group compliance` notation. Additionally, I commented out one of the tests that I was not totally sure of. (unsure if `setAttribute()` should work with empty string `''` values.
yuktea
marked this pull request as draft
April 15, 2022 08:11
yuktea
marked this pull request as ready for review
April 15, 2022 08:24
tidal
reviewed
Apr 15, 2022
Removed `$span->end()` calls as they shouldn't be necessary
yuktea
marked this pull request as draft
April 16, 2022 20:00
yuktea
changed the title
Test to get default tracer. Also, added `@group` php unit annotation for tests to check specification compliance
yuktea
marked this pull request as ready for review
April 16, 2022 21:09
tidal
approved these changes
Apr 17, 2022
Member
|
@yuktea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some additional tests for the Span Builder SDK that verify:
startSpan()should not workplus some additional tests for setting null and empty string values to attributes.
UPDATE: I commented out one of the tests that I was not totally sure of.
(unsure if
setAttribute()should work with empty string''values.)