Revert "replace E_USER_NOTICE with E_USER_DEPRECATED"#655
Merged
Conversation
This reverts commit 72816bb.
Contributor
Author
|
@ivoba - you can catch one of us on slack if you'd like more details :) |
Codecov Report
@@ Coverage Diff @@
## main #655 +/- ##
=========================================
Coverage 84.27% 84.27%
Complexity 1146 1146
=========================================
Files 127 127
Lines 2772 2772
=========================================
Hits 2336 2336
Misses 436 436
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
bobstrecansky
approved these changes
Apr 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #647
We were discussing this PR internally, and think that the original behaviour was correct and intentional - the BC layer is for the protection of code running in production mode, but not development mode.