replace E_USER_NOTICE with E_USER_DEPRECATED#647
Merged
bobstrecansky merged 2 commits intoApr 2, 2022
Conversation
ivoba
requested review from
bobstrecansky,
brettmc,
tidal and
zsistla
as code owners
March 31, 2022 10:05
|
Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one. |
|
|
brettmc
approved these changes
Mar 31, 2022
Codecov Report
@@ Coverage Diff @@
## main #647 +/- ##
============================================
- Coverage 84.45% 84.45% -0.01%
Complexity 1141 1141
============================================
Files 127 127
Lines 2767 2766 -1
============================================
- Hits 2337 2336 -1
Misses 430 430
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
brettmc
added a commit
that referenced
this pull request
Apr 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since it is a notice about a deprecation it should also use E_USER_DEPRECATED as log level.
NOTICE seems to be not the appropriate log level.
In my case it broke the application in dev mode where Notices are considered errors.