Add test based on the Jaeger spec#645
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #645 +/- ##
=========================================
Coverage 84.45% 84.45%
Complexity 1141 1141
=========================================
Files 127 127
Lines 2766 2766
=========================================
Hits 2336 2336
Misses 430 430
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
brettmc
reviewed
Mar 31, 2022
Grunet
marked this pull request as ready for review
March 31, 2022 01:57
brettmc
approved these changes
Mar 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a specific test based on the spec example, since I tried at least twice at the logic and missed both times until @saktib fixed it all up...
Also fixes up some flakiness I noticed after running the tests a few times, like here https://github.com/open-telemetry/opentelemetry-php/runs/5763933166?check_suite_focus=true