Created ResouceInfoFactory class#628
Merged
Merged
Conversation
kishannsangani
requested review from
bobstrecansky,
brettmc,
tidal and
zsistla
as code owners
March 23, 2022 18:58
Codecov Report
@@ Coverage Diff @@
## main #628 +/- ##
============================================
- Coverage 85.21% 83.73% -1.48%
Complexity 1087 1087
============================================
Files 118 119 +1
Lines 2637 2637
============================================
- Hits 2247 2208 -39
- Misses 390 429 +39
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
brettmc
approved these changes
Mar 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created ResourceInfoFactory class and moved merge, defaultResource, and emptyResource methods from ResourceInfo to ResourceInfoFactory.
Fixes #621.