Make AttributesInterface immutable#542
Conversation
Codecov Report
@@ Coverage Diff @@
## main #542 +/- ##
============================================
+ Coverage 95.18% 95.28% +0.09%
- Complexity 934 951 +17
============================================
Files 94 96 +2
Lines 2286 2334 +48
============================================
+ Hits 2176 2224 +48
Misses 110 110
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| (null === $this->attributes) ? 0 : $this->attributes->getTotalAddedValues(), | ||
| $this->totalRecordedEvents, | ||
| $this->attributes->build(), | ||
| max(0, $this->droppedEventsCount), |
There was a problem hiding this comment.
I've spent a while to understand why the count could be negative number. Very interesting approach to store the limit value.
There was a problem hiding this comment.
Should I revert this change or is adding a comment to the droppedLinksCount and droppedEventsCount properties sufficient?
0d44b43 to
89c510a
Compare
|
Hey @Nevay - are you still planning on updating this PR? |
|
Closing this due to inactivity; please feel free to reopen if you'd like to! |
4 participants
Makes
AttributesInterfaceimmutable by introducingAttributesBuilderInterfaceas mutable builder.Related:
#521 (comment)
#520