Add metric aggregation implementation#520
Closed
Nevay wants to merge 1 commit into
Closed
Conversation
Adds synchronous and asynchronous metric aggregations with support for multiple readers per aggregation.
Member
I don't see any objections, and honestly the Metrics API/SDK could need some polish. So this is very welcome!
Did you take a look into rector? |
Contributor
|
Hey @Nevay - are you still planning on updating this PR? |
Contributor
|
Closing this due to inactivity; please feel free to reopen if you'd like to! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds synchronous and asynchronous metric aggregations with support for multiple readers per aggregation.
Intended as internal implementation of meter instruments; on instrument creation:
Meterwould create aMetricStreamfor each registeredView,MetricReaders would register as reader for eachMetricStream.Creating this as draft to gather some feedback before I start working on the todos. Are there objections to implementing the metrics SDK this way?
TODOs: