fix(ResourceInfoFactory): Align ResourceInfoFactory detectors to otel specification by jerrytfleung · Pull Request #2006 · open-telemetry/opentelemetry-php

jerrytfleung · 2026-07-08T17:24:39Z

Problem

From https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/resource/sdk.md#specifying-resource-information-via-an-environment-variable, user provided resource information has higher priority and OTEL_SERVICE_NAME has the highest priority. However, with current implementation, the service.name detected by the open-telemetry/detector-azure will replace the service.name from OTEL_SERVICE_NAME which doesn't meet the specification.

Fix

Corrected the ordering of the resource detectors in default and env-provided detectors.

Copilot

Pull request overview

This PR aligns ResourceInfoFactory’s detector merge order with the OpenTelemetry resource specification so that user-provided resource info (and specifically OTEL_SERVICE_NAME) takes precedence over vendor/registry-provided detectors (e.g., Azure).

Changes:

Reordered default (“all detectors”) composition so registry detectors run before Environment, Sdk, and Service.
Reordered env-configured detector composition so registry-requested detectors run before mandatory Environment, Sdk, and Service.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot Autofix powered by AI <[email protected]>

codecov · 2026-07-09T21:11:42Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.05%. Comparing base (697aefd) to head (2e882d5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #2006      +/-   ##
============================================
+ Coverage     68.00%   68.05%   +0.04%     
  Complexity     3078     3078              
============================================
  Files           459      459              
  Lines          9023     9024       +1     
============================================
+ Hits           6136     6141       +5     
+ Misses         2887     2883       -4

Flag	Coverage Δ
8.1	`67.73% <100.00%> (-0.02%)`	⬇️
8.2	`67.97% <100.00%> (+0.06%)`	⬆️
8.3	`67.95% <100.00%> (+0.04%)`	⬆️
8.4	`67.96% <100.00%> (+0.06%)`	⬆️
8.5	`67.93% <100.00%> (-0.04%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/SDK/Resource/ResourceInfoFactory.php	`97.91% <100.00%> (+0.04%)`	⬆️

... and 6 files with indirect coverage changes

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 697aefd...2e882d5. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

…or-service-name-again Add regression coverage for `service.name` precedence over registry detectors

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot Autofix powered by AI <[email protected]>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot Autofix powered by AI <[email protected]>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot Autofix powered by AI <[email protected]>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot Autofix powered by AI <[email protected]>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Align ResourceInfoFactory detectors to otel specification

b0ac9a4

jerrytfleung requested a review from a team as a code owner July 8, 2026 17:24

bobstrecansky requested a review from Copilot July 9, 2026 20:11

Copilot started reviewing on behalf of bobstrecansky July 9, 2026 20:12 View session

Copilot AI reviewed Jul 9, 2026

View reviewed changes

Comment thread src/SDK/Resource/ResourceInfoFactory.php Outdated

Potential fix for pull request finding

9acd3cc

Co-authored-by: Copilot Autofix powered by AI <[email protected]>

jerrytfleung requested a review from Copilot July 9, 2026 21:10

Copilot started reviewing on behalf of jerrytfleung July 9, 2026 21:10 View session

Copilot AI reviewed Jul 9, 2026

View reviewed changes

Comment thread src/SDK/Resource/ResourceInfoFactory.php

Copilot AI and others added 2 commits July 9, 2026 21:17

Add regression tests for OTEL service.name precedence

6a2651d

Merge pull request #7 from jerrytfleung/copilot/add-regression-test-f…

fd62c75

…or-service-name-again Add regression coverage for `service.name` precedence over registry detectors

jerrytfleung requested a review from Copilot July 9, 2026 21:37

Copilot started reviewing on behalf of jerrytfleung July 9, 2026 21:37 View session

Copilot AI reviewed Jul 9, 2026

View reviewed changes

Comment thread tests/Unit/SDK/Resource/ResourceInfoFactoryTest.php Outdated

jerrytfleung and others added 4 commits July 9, 2026 14:56

Potential fix for pull request finding

b2f9374

Co-authored-by: Copilot Autofix powered by AI <[email protected]>

Fixed the code

b229c0e

Fixed style

c3c4490

Added override

dcff956

jerrytfleung requested a review from Copilot July 9, 2026 23:01

Copilot started reviewing on behalf of jerrytfleung July 9, 2026 23:01 View session

Copilot AI reviewed Jul 9, 2026

View reviewed changes

Comment thread tests/Unit/SDK/Resource/ResourceInfoFactoryTest.php

Potential fix for pull request finding

fc3956a

Co-authored-by: Copilot Autofix powered by AI <[email protected]>

bobstrecansky requested a review from Copilot July 10, 2026 13:33

Copilot started reviewing on behalf of bobstrecansky July 10, 2026 13:33 View session

Copilot AI reviewed Jul 10, 2026

View reviewed changes

Comment thread tests/Unit/SDK/Resource/ResourceInfoFactoryTest.php

Potential fix for pull request finding

855be63

Co-authored-by: Copilot Autofix powered by AI <[email protected]>

jerrytfleung requested a review from Copilot July 10, 2026 15:40

Copilot started reviewing on behalf of jerrytfleung July 10, 2026 15:45 View session

Copilot AI reviewed Jul 10, 2026

View reviewed changes

Comment thread tests/Unit/SDK/Resource/ResourceInfoFactoryTest.php

jerrytfleung and others added 2 commits July 10, 2026 08:51

Potential fix for pull request finding

050e0b6

Co-authored-by: Copilot Autofix powered by AI <[email protected]>

Fixed style

2e882d5

jerrytfleung requested a review from Copilot July 10, 2026 16:25

Copilot started reviewing on behalf of jerrytfleung July 10, 2026 16:29 View session

Copilot AI reviewed Jul 10, 2026

View reviewed changes

bobstrecansky approved these changes Jul 13, 2026

View reviewed changes

bobstrecansky merged commit f45aa11 into open-telemetry:main Jul 13, 2026
12 checks passed

jerrytfleung mentioned this pull request Jul 14, 2026

Correct SW_APM_SERVICE_KEY precedence according to the upstream fix solarwinds/apm-php#187

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(ResourceInfoFactory): Align ResourceInfoFactory detectors to otel specification#2006

fix(ResourceInfoFactory): Align ResourceInfoFactory detectors to otel specification#2006
bobstrecansky merged 12 commits into
open-telemetry:mainfrom
jerrytfleung:resource_detectors_ordering

jerrytfleung commented Jul 8, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

codecov Bot commented Jul 9, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

jerrytfleung commented Jul 8, 2026

Problem

Fix

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

codecov Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Jul 9, 2026 •

edited

Loading