fix(sdk): require sem-conv ^1.38 for VERSION_1_38_0 constant#2003
Merged
bobstrecansky merged 1 commit intoJul 9, 2026
Merged
Conversation
|
|
Contributor
Author
|
@open-telemetry/php-approvers this is a small, self-contained dependency-constraint fix for #1922 — would appreciate a review when you have a moment. 🙏 |
SDK resource detectors reference `Version::VERSION_1_38_0`, added in open-telemetry/sem-conv 1.38.0, but composer.json allowed `^1.36.0`. Resolving sem-conv to 1.36 or 1.37 (e.g. via `composer update -m`) triggers a fatal "Undefined constant ...VERSION_1_38_0" at runtime in the detectors. Bump the constraint so the constant is guaranteed to exist. Fixes open-telemetry#1922 - Rollback: revert commit; restores `^1.36.0` constraint. Risk-Level: low AI-Agent: claude-opus-4-8
PuvaanRaaj
force-pushed
the
fix/1922-semconv-constraint
branch
from
July 8, 2026 07:24
9d350d2 to
2a10c5d
Compare
Contributor
Author
|
/easycla |
ChrisLightfootWild
approved these changes
Jul 8, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2003 +/- ##
=========================================
Coverage 68.00% 68.00%
Complexity 3078 3078
=========================================
Files 459 459
Lines 9023 9023
=========================================
Hits 6136 6136
Misses 2887 2887
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #1922.
SDK resource detectors (
Environment,Host,Sdk,Process,Service,ServiceInstance,Composer) referenceOpenTelemetry\SemConv\Version::VERSION_1_38_0, which was introduced inopen-telemetry/sem-conv1.38.0. Howeversrc/SDK/composer.jsononly required^1.36.0.Resolving
sem-convto 1.36 or 1.37 (easy to hit viacomposer update --minimal-changes) produces a fatal error at runtime:Fix
Bump the
open-telemetry/sem-convconstraint in the SDK package from^1.36.0to^1.38.0so the referenced constant is guaranteed to exist.Contribdoes not reference anyVersion::VERSION_1_3xconstant, so its constraint is left unchanged.🤖 Generated with Claude Code