fix(sdk): guard Span::setAttributes() against mutation after end()#1999
Merged
bobstrecansky merged 1 commit intoJul 6, 2026
Merged
Conversation
setAttribute() already no-ops once a span has ended, but setAttributes() lacked the same hasEnded guard, letting attributes leak in after end() in violation of the OTel spec.
ChrisLightfootWild
approved these changes
Jul 1, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1999 +/- ##
============================================
+ Coverage 68.02% 68.08% +0.06%
- Complexity 3075 3077 +2
============================================
Files 459 459
Lines 9017 9022 +5
============================================
+ Hits 6134 6143 +9
+ Misses 2883 2879 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setAttribute() already no-ops once a span has ended, but setAttributes() lacked the same hasEnded guard, letting attributes leak in after end() in violation of the OTel spec.