Skip to content

Add trigger_error as Log Destination Option#1939

Merged
bobstrecansky merged 2 commits into
open-telemetry:mainfrom
SoulofAkuma:main
Apr 29, 2026
Merged

Add trigger_error as Log Destination Option#1939
bobstrecansky merged 2 commits into
open-telemetry:mainfrom
SoulofAkuma:main

Conversation

@SoulofAkuma

@SoulofAkuma SoulofAkuma commented Apr 19, 2026

Copy link
Copy Markdown
Contributor

This PR adds trigger_error as an additional option for OTEL_PHP_LOG_DESTINATION.

I will add a corresponding PR to https://github.com/open-telemetry/opentelemetry.io to document this new option and will reference this PR here as soon as that is done.

Fixes #1473

@SoulofAkuma
SoulofAkuma requested a review from a team as a code owner April 19, 2026 13:02
@linux-foundation-easycla

linux-foundation-easycla Bot commented Apr 19, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ChrisLightfootWild / name: Chris Lightfoot-Wild (130166f)
  • ✅ login: SoulofAkuma / name: Mika Allert (130166f, da9f2d8)

@SoulofAkuma

SoulofAkuma commented Apr 19, 2026

Copy link
Copy Markdown
Contributor Author

I'm gonna have to double check whether I classify as an individual or corporate contributor in this scenario. I am participating in the bloomberg open source series with OTel.

@SoulofAkuma SoulofAkuma mentioned this pull request Apr 19, 2026
Merged
4 tasks
@SoulofAkuma

SoulofAkuma commented Apr 19, 2026

Copy link
Copy Markdown
Contributor Author

Submitted corressponding documentation update: open-telemetry/opentelemetry.io#9685

ChrisLightfootWild
ChrisLightfootWild reviewed Apr 19, 2026
View reviewed changes
Comment thread tests/Unit/API/Behavior/Internal/LogWriterFactoryTest.php Outdated
@codecov

codecov Bot commented Apr 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.09%. Comparing base (40d751e) to head (130166f).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...avior/Internal/LogWriter/TriggerErrorLogWriter.php 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1939      +/-   ##
============================================
- Coverage     68.10%   68.09%   -0.01%     
- Complexity     3021     3023       +2     
============================================
  Files           450      451       +1     
  Lines          8820     8824       +4     
============================================
+ Hits           6007     6009       +2     
- Misses         2813     2815       +2
Flag Coverage Δ
8.1 67.83% <50.00%> (-0.07%) ⬇️
8.2 68.07% <50.00%> (+0.03%) ⬆️
8.3 68.03% <50.00%> (-0.04%) ⬇️
8.4 68.04% <50.00%> (-0.04%) ⬇️
8.5 67.19% <50.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/API/Behavior/Internal/LogWriterFactory.php 80.95% <100.00%> (+2.00%) ⬆️
...avior/Internal/LogWriter/TriggerErrorLogWriter.php 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40d751e...130166f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SoulofAkuma

SoulofAkuma commented Apr 24, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the approval @ChrisLightfootWild . Do you have permissions to review the documentation PR open-telemetry/opentelemetry.io#9685 as well?

@ChrisLightfootWild

ChrisLightfootWild commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

Thanks for the approval @ChrisLightfootWild . Do you have permissions to review the documentation PR open-telemetry/opentelemetry.io#9685 as well?

Yeah, I can take a look.

@vitorvasc

vitorvasc commented Apr 28, 2026

Copy link
Copy Markdown
Member

Hi @SoulofAkuma @ChrisLightfootWild!

Re: open-telemetry/opentelemetry.io#9685, it looks good to me! I believe we should wait until this PR is merged and released before updating the upstream documentation. Is that correct?

@bobstrecansky
bobstrecansky merged commit c021e79 into open-telemetry:main Apr 29, 2026
11 of 12 checks passed
@Devansh1093 Devansh1093 mentioned this pull request Jun 2, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bobstrecansky bobstrecansky bobstrecansky approved these changes
@ChrisLightfootWild ChrisLightfootWild ChrisLightfootWild approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

To use trigger_error instead of error_log

4 participants

@SoulofAkuma @ChrisLightfootWild @vitorvasc @bobstrecansky