Skip to content

Fix span suppression with non recording spans#1921

Merged
bobstrecansky merged 1 commit into
open-telemetry:mainfrom
Nevay:fix/span-suppression-non-recording-spans
Apr 8, 2026
Merged

Fix span suppression with non recording spans#1921
bobstrecansky merged 1 commit into
open-telemetry:mainfrom
Nevay:fix/span-suppression-non-recording-spans

Conversation

@Nevay

@Nevay Nevay commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

Part of #1579

@Nevay
Nevay requested a review from a team as a code owner March 23, 2026 18:20
@codecov

codecov Bot commented Mar 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 4.34783% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.17%. Comparing base (938c2bc) to head (fad860c).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/SDK/Trace/NonRecordingSpan.php 0.00% 22 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1921      +/-   ##
============================================
- Coverage     68.29%   68.17%   -0.13%     
- Complexity     3009     3021      +12     
============================================
  Files           449      450       +1     
  Lines          8798     8820      +22     
============================================
+ Hits           6009     6013       +4     
- Misses         2789     2807      +18     
Flag Coverage Δ
8.1 67.86% <4.34%> (-0.15%) ⬇️
8.2 68.07% <4.34%> (-0.20%) ⬇️
8.3 68.09% <4.34%> (-0.13%) ⬇️
8.4 68.06% <4.34%> (-0.16%) ⬇️
8.5 67.27% <4.34%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/SDK/Trace/SpanBuilder.php 90.58% <100.00%> (ø)
src/SDK/Trace/NonRecordingSpan.php 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 938c2bc...fad860c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Nevay
Nevay force-pushed the fix/span-suppression-non-recording-spans branch from a152227 to fad860c Compare March 23, 2026 18:23
@bobstrecansky
bobstrecansky merged commit 6fef63f into open-telemetry:main Apr 8, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants