Skip to content

Allow span suppression strategy configuration using file-based and env-based config#1920

Merged
bobstrecansky merged 2 commits into
open-telemetry:mainfrom
Nevay:feature/span-suppression-configuration
Apr 29, 2026
Merged

Allow span suppression strategy configuration using file-based and env-based config#1920
bobstrecansky merged 2 commits into
open-telemetry:mainfrom
Nevay:feature/span-suppression-configuration

Conversation

@Nevay

@Nevay Nevay commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

Part of #1579, adds experimental support for SpanSuppressionStrategy configuration using distribution configuration.

The spankind and semconv strategies are currently equivalent as we do not provide SemanticConventionResolver yet.

Env based

OTEL_EXPERIMENTAL_SPAN_SUPPRESSION_STRATEGY=none
OTEL_EXPERIMENTAL_SPAN_SUPPRESSION_STRATEGY=spankind
OTEL_EXPERIMENTAL_SPAN_SUPPRESSION_STRATEGY=semconv

File based

distribution:
  opentelemetry_php:
    span_suppression_strategy/development:
      spankind:
distribution:
  opentelemetry_php:
    span_suppression_strategy/development:
      semconv:

@Nevay
Nevay requested a review from a team as a code owner March 23, 2026 18:19
@codecov

codecov Bot commented Mar 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 21.31148% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.81%. Comparing base (938c2bc) to head (a722b5c).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...ider/Distribution/DistributionConfigurationSdk.php 0.00% 11 Missing ⚠️
...gEnv/Distribution/DistributionConfigurationSdk.php 0.00% 9 Missing ⚠️
.../Config/SDK/ComponentProvider/OpenTelemetrySdk.php 0.00% 6 Missing ⚠️
...c/SDK/Common/Distribution/DistributionRegistry.php 0.00% 5 Missing ⚠️
...tProvider/Trace/SpanSuppressionStrategySemConv.php 0.00% 4 Missing ⚠️
...Provider/Trace/SpanSuppressionStrategySpanKind.php 0.00% 4 Missing ⚠️
...ConfigEnv/Trace/SpanSuppressionStrategySemConv.php 0.00% 4 Missing ⚠️
...onfigEnv/Trace/SpanSuppressionStrategySpanKind.php 0.00% 4 Missing ⚠️
src/SDK/Common/Distribution/SdkDistribution.php 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1920      +/-   ##
============================================
- Coverage     68.29%   67.81%   -0.49%     
- Complexity     3009     3042      +33     
============================================
  Files           449      458       +9     
  Lines          8798     8881      +83     
============================================
+ Hits           6009     6023      +14     
- Misses         2789     2858      +69
Flag Coverage Δ
8.1 67.58% <21.31%> (-0.44%) ⬇️
8.2 67.74% <21.31%> (-0.53%) ⬇️
8.3 67.75% <21.31%> (-0.47%) ⬇️
8.4 67.74% <21.31%> (-0.47%) ⬇️
8.5 66.93% <21.31%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/SDK/SdkAutoloader.php 92.66% <100.00%> (+0.69%) ⬆️
src/SDK/Common/Distribution/SdkDistribution.php 0.00% <0.00%> (ø)
...tProvider/Trace/SpanSuppressionStrategySemConv.php 0.00% <0.00%> (ø)
...Provider/Trace/SpanSuppressionStrategySpanKind.php 0.00% <0.00%> (ø)
...ConfigEnv/Trace/SpanSuppressionStrategySemConv.php 0.00% <0.00%> (ø)
...onfigEnv/Trace/SpanSuppressionStrategySpanKind.php 0.00% <0.00%> (ø)
...c/SDK/Common/Distribution/DistributionRegistry.php 0.00% <0.00%> (ø)
.../Config/SDK/ComponentProvider/OpenTelemetrySdk.php 0.00% <0.00%> (ø)
...gEnv/Distribution/DistributionConfigurationSdk.php 0.00% <0.00%> (ø)
...ider/Distribution/DistributionConfigurationSdk.php 0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 938c2bc...a722b5c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Nevay
Nevay force-pushed the feature/span-suppression-configuration branch from 87d320f to 723794b Compare March 23, 2026 18:24
@Nevay
Nevay force-pushed the feature/span-suppression-configuration branch from 723794b to 29bf4c2 Compare March 23, 2026 18:44
Nevay
Nevay commented Mar 23, 2026
View reviewed changes
Comment thread src/Config/SDK/ComponentProvider/Distribution/DistributionConfigurationSdk.php Outdated
@bobstrecansky
bobstrecansky merged commit 566ecb7 into open-telemetry:main Apr 29, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bobstrecansky bobstrecansky bobstrecansky approved these changes
@ChrisLightfootWild ChrisLightfootWild ChrisLightfootWild approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Nevay @bobstrecansky @ChrisLightfootWild