Skip to content

Fix getLabel() deprecation warning with Protobuf 4.33+#1854

Merged
brettmc merged 2 commits into
open-telemetry:mainfrom
jspaetzel:patch-1
Jan 15, 2026
Merged

Fix getLabel() deprecation warning with Protobuf 4.33+#1854
brettmc merged 2 commits into
open-telemetry:mainfrom
jspaetzel:patch-1

Conversation

@jspaetzel

@jspaetzel jspaetzel commented Jan 14, 2026

Copy link
Copy Markdown
Contributor

getLabel is deprecated. Use isRequired or isRepeated instead.

@jspaetzel
Fix getLabel() deprecation warning with Protobuf 4.33+
a61d3cf 
getLabel is deprecated. Use isRequired or isRepeated instead.
@jspaetzel
jspaetzel requested a review from a team as a code owner January 14, 2026 23:08
@welcome

welcome Bot commented Jan 14, 2026

Copy link
Copy Markdown

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

@jspaetzel jspaetzel mentioned this pull request Jan 14, 2026
Closed
@jspaetzel
Remove unused import for GPBLabel
181c668 
Removed unused GPBLabel import.
@codecov

codecov Bot commented Jan 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 68.32%. Comparing base (f413878) to head (181c668).

Files with missing lines Patch % Lines
src/Contrib/Otlp/ProtobufSerializer.php 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1854      +/-   ##
============================================
+ Coverage     68.30%   68.32%   +0.01%     
  Complexity     2976     2976              
============================================
  Files           449      449              
  Lines          8724     8726       +2     
============================================
+ Hits           5959     5962       +3     
+ Misses         2765     2764       -1
Flag Coverage Δ
8.1 68.12% <0.00%> (+0.02%) ⬆️
8.5 67.48% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Contrib/Otlp/ProtobufSerializer.php 15.62% <0.00%> (ø)

... and 5 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f413878...181c668. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brettmc
brettmc merged commit b4b274d into open-telemetry:main Jan 15, 2026
6 of 9 checks passed
@jspaetzel
jspaetzel deleted the patch-1 branch January 15, 2026 23:35
@gregtyler gregtyler mentioned this pull request Jan 30, 2026
Closed
Nevay added a commit to Nevay/opentelemetry-php that referenced this pull request Jan 30, 2026
@Nevay
Revert "Fix getLabel() deprecation warning with Protobuf 4.33+ (open-…
4849b16 
…telemetry#1854)"

This reverts commit b4b274d.
@Nevay Nevay mentioned this pull request Jan 30, 2026
Merged
brettmc pushed a commit that referenced this pull request Feb 5, 2026
@Nevay
Revert "Fix getLabel() deprecation warning with Protobuf 4.33+ (#1854)…
26a2a4e 
…" (#1880)

This reverts commit b4b274d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettmc brettmc brettmc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jspaetzel @brettmc