The committers listed above are authorized under a signed CLA.

• ✅ login: Orest-Divintari / name: Orest Divintari (0bc6962, 3703449, 6e6a910, 90f00cc)

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.37%. Comparing base (f413878) to head (0bc6962).
⚠️ Report is 2 commits behind head on main.

@@             Coverage Diff              @@
##               main    #1839      +/-   ##
============================================
+ Coverage     68.30%   68.37%   +0.06%     
  Complexity     2976     2976              
============================================
  Files           449      449              
  Lines          8724     8726       +2     
============================================
+ Hits           5959     5966       +7     
+ Misses         2765     2760       -5     

hi @brettmc @bobstrecansky could you please have a look when you have time ?
locally every check is passing

I'll be happy to review once the CLA is signed. Thanks in advance @Orest-Divintari !

I'll be happy to review once the CLA is signed. Thanks in advance @Orest-Divintari !

Hi @brettmc @bobstrecansky and happy new year

The agreement has been signed, could you please have a look whenever you have time ?

Hi @Orest-Divintari thanks for the contribution. Could you please take a look at the failing phpstan errors, which look relevant to this change? thanks!

edit: nvm, it's only failing in 8.1, which I think we've dropped support for since it's no longer officially supported

Hi @Orest-Divintari thanks for the contribution. Could you please take a look at the failing phpstan errors, which look relevant to this change? thanks!

edit: nvm, it's only failing in 8.1, which I think we've dropped support for since it's no longer officially supported

hi @brettmc thanks for taking the time to review and merge it
could you also tag it please ?

hi @brettmc thanks for tagging https://github.com/opentelemetry-php/config-sdk/releases/tag/0.5.0

is it possible to also tag https://github.com/opentelemetry-php/api 1.8 because https://github.com/opentelemetry-php/config-sdk/releases/tag/0.5.0 requires api:1.8

@Orest-Divintari that might need to wait a couple of days, sorry. There aren't any pending changes in the API...that requirement came from https://github.com/open-telemetry/opentelemetry-php/pull/1729/files#diff-2bfa3bf55090de7d62d81745d2cf6ec24ef4a3ec2eb9504725f5f963416e4b3e but I don't see any clues as to why the bump.

In the meantime, can you try aliasing the API to 1.8 in composer.json? There's one PR open in draft which touches the API so I hope that can be merged quickly.

@Orest-Divintari that might need to wait a couple of days, sorry. There aren't any pending changes in the API...that requirement came from https://github.com/open-telemetry/opentelemetry-php/pull/1729/files#diff-2bfa3bf55090de7d62d81745d2cf6ec24ef4a3ec2eb9504725f5f963416e4b3e but I don't see any clues as to why the bump.

In the meantime, can you try aliasing the API to 1.8 in composer.json? There's one PR open in draft which touches the API so I hope that can be merged quickly.

hi @brettmc thanks for the reply.

I have tagged the API in the composer already with the hash commit as a temporary solution because the sdk configuration required at least api:1.8.

I just wanted to check if that is something that could be resolved on your side so i can update the composer to use normal versions instead of specific has commits

The issue is that https://packagist.org/packages/open-telemetry/sdk-configuration 0.5.0 depends on open-telemetry/api: ^1.8. That does not exist.

So either it should be lowered again in sdk-configuration, or open-telemetry/api should be tagged.

This was done in opentelemetry-php/config-sdk@5d8abf3 but I fail to understand why.

@Nevay Would be great if you could help out here.

opentelemetry-php/config-sdk@5d8abf3 uses a newly added method Configuration\Context::withExtension() (related commit in the API package: opentelemetry-php/api@63d4d9c), calling Configuration::create() with API < 1.8.0-dev would fail.