feat: Implement onEnding interface of Span Processor in Trace SDK#1785
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1785 +/- ##
============================================
- Coverage 68.49% 68.43% -0.07%
- Complexity 2970 2974 +4
============================================
Files 448 448
Lines 8714 8722 +8
============================================
Hits 5969 5969
- Misses 2745 2753 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
|
||
| $this->endEpochNanos = $endEpochNanos ?? Clock::getDefault()->now(); | ||
| if ($this->spanProcessor instanceof ExtendedSpanProcessorInterface) { | ||
| $this->spanProcessor->onEnding($this); |
There was a problem hiding this comment.
Must prevent modifications from outside of the ::onEnding() callbacks.
Should backport the 2.x Span::end() implementation #1483 if we want to add this to 1.x.
There was a problem hiding this comment.
I see.
Done. Backported the related code and test cases from #1483.
3 participants
This PR is to implement onEnding interface of Span Processor in Trace SDK.
Changes:
Span::end()function