Skip to content

[SemConv] Add TLS trace attributes to new structure introduced in #1659#1695

Merged
brettmc merged 2 commits into
open-telemetry:mainfrom
WyriHaximus-labs:semconv-add-tls
Aug 24, 2025
Merged

[SemConv] Add TLS trace attributes to new structure introduced in #1659#1695
brettmc merged 2 commits into
open-telemetry:mainfrom
WyriHaximus-labs:semconv-add-tls

Conversation

@WyriHaximus

@WyriHaximus WyriHaximus commented Aug 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

While working on ReactPHP Socket autoinstrumentation, I noticed that the TLS_* trace attributes weren't added. This PR introduces them into the new structure.

@WyriHaximus
WyriHaximus requested a review from a team as a code owner August 24, 2025 10:23
@welcome

welcome Bot commented Aug 24, 2025

Copy link
Copy Markdown

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Aug 24, 2025 •
edited
Loading

Copy link
Copy Markdown

CLA Signed

  • ✅login: WyriHaximus / name: Cees-Jan Kiewiet / (86c2b6c)
  • ✅login: WyriHaximus / name: Cees-Jan Kiewiet / (86c2b6c, e705960)

The committers listed above are authorized under a signed CLA.

@WyriHaximus WyriHaximus mentioned this pull request Aug 24, 2025
Closed
brettmc
brettmc approved these changes Aug 24, 2025
View reviewed changes

@brettmc brettmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just waiting on CLA signing then I'll merge.

@codecov

codecov Bot commented Aug 24, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.40%. Comparing base (2e0a084) to head (e705960).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1695      +/-   ##
============================================
- Coverage     68.45%   68.40%   -0.06%     
  Complexity     2878     2878              
============================================
  Files           430      430              
  Lines          8759     8757       -2     
============================================
- Hits           5996     5990       -6     
- Misses         2763     2767       +4
Flag Coverage Δ
8.1 68.13% <ø> (-0.02%) ⬇️
8.2 68.28% <ø> (-0.10%) ⬇️
8.3 68.34% <ø> (ø)
8.4 68.33% <ø> (-0.03%) ⬇️
8.5 68.33% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 4 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e0a084...e705960. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brettmc
brettmc merged commit 5fbbcee into open-telemetry:main Aug 24, 2025
7 of 8 checks passed
@WyriHaximus
WyriHaximus deleted the semconv-add-tls branch August 24, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettmc brettmc brettmc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@WyriHaximus @brettmc