Merged
Conversation
use rector (and psalm) to add Override attributes, and add symfony polyfill to provide Override in earlier php versions
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1666 +/- ##
============================================
+ Coverage 68.70% 68.77% +0.06%
- Complexity 2854 2857 +3
============================================
Files 425 425
Lines 8699 8704 +5
============================================
+ Hits 5977 5986 +9
+ Misses 2722 2718 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
there are some things in our code that deptrac doesn't understand or are missing for some php versions. stub them to quieten all those violation warnings
bobstrecansky
approved these changes
Jul 17, 2025
Nevay
reviewed
Jul 18, 2025
src/SDK/Metrics/Aggregation/ExplicitBucketHistogramAggregation.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Chris Lightfoot-Wild <[email protected]>
brettmc
force-pushed
the
psalm-override-green
branch
from
38f3b92 to
580d7dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix up the big list of psalm+phan+deptrac complaints in our github actions, upgrade some of the tools to latest and address some issues. This fixes the issues complaining about repeated attributes and missing
Overrideattribute, but also has some new things to complain about.Notably: