adding metrics semconv#1633
Conversation
|
When this is merged, I think we should create an issue to update our metrics generation from span and log processors to use the otel semconv attributes. They didn't exist when we first implemented. |
|
Any opinions on how I've split each group into its own file? |
I think I prefer it this way 👍 I'm not entirely sure on the units of measure though, although I see they are coming directly from the schemas - so maybe not much we could do with them. e.g. |
The spec suggests a similar structure:
|
this better aligns with the guidance in spec
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1633 +/- ##
============================================
- Coverage 68.68% 68.64% -0.05%
Complexity 2854 2854
============================================
Files 425 425
Lines 8699 8699
============================================
- Hits 5975 5971 -4
- Misses 2724 2728 +4
Flags with carried forward coverage won't be shown. Click here to find out more. see 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Generate some initial metrics SemConv files. I've chosen to start small, with just
httpandotelgroups until we need more, and thought one file per group seemed neater.Closes: #1613