update weaver to 0.15.2#1629
Merged
Merged
Conversation
brettmc
commented
Jun 12, 2025
| * | ||
| * @see TraceAttributes::ANDROID_APP_STATE | ||
| */ | ||
| public const ANDROID_APP_STATE_CREATED = 'created'; |
Contributor
Author
There was a problem hiding this comment.
A lot of this is not useful to PHP. We probably should have been more selective way back when we started generating semconv, but here we are. To remove them now would technically be BC, and although there are some new android, cpython etc semconvs in this PR, there are also existing ones, and I don't want to deal with it down at the level of individual items.
bobstrecansky
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when generating metrics semconv, I saw a bunch of unexpected changes to trace/resource attributes, which I assume is related to changes in weaver since the semconv version has not changed. Splitting these changes off into a separate PR to make the upcoming metrics one simpler.