Ignore TypeError in ::serializeToJsonString() if google/protobuf ^4.31 and ext-protobuf <4.31 are installed#1598
Merged
brettmc merged 1 commit intoMay 17, 2025
Conversation
….31` are installed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1598 +/- ##
============================================
- Coverage 69.46% 69.29% -0.18%
- Complexity 2804 2805 +1
============================================
Files 414 414
Lines 8584 8585 +1
============================================
- Hits 5963 5949 -14
- Misses 2621 2636 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
brettmc
approved these changes
May 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1597 by ignoring the
TypeError; could alternatively check for installed extension version but this fix seems simpler.