Skip to content

Use protobuf PrintOptions if available#1593

Merged
brettmc merged 1 commit into
open-telemetry:mainfrom
Nevay:feature/protobuf-printoptions
May 12, 2025
Merged

Use protobuf PrintOptions if available#1593
brettmc merged 1 commit into
open-telemetry:mainfrom
Nevay:feature/protobuf-printoptions

Conversation

@Nevay

@Nevay Nevay commented May 11, 2025

Copy link
Copy Markdown
Contributor

Resolves #978, PrintOptions is available in ^4.31.

@Nevay
Nevay requested a review from a team as a code owner May 11, 2025 19:44
@codecov

codecov Bot commented May 11, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 70.93%. Comparing base (b5a5ac7) to head (d09ca30).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/Contrib/Otlp/ProtobufSerializer.php 0.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1593      +/-   ##
============================================
+ Coverage     70.82%   70.93%   +0.11%     
- Complexity     2768     2769       +1     
============================================
  Files           407      407              
  Lines          8359     8362       +3     
============================================
+ Hits           5920     5932      +12     
+ Misses         2439     2430       -9     
Flag Coverage Δ
8.1 70.53% <0.00%> (-0.03%) ⬇️
8.2 70.77% <0.00%> (-0.01%) ⬇️
8.3 70.76% <0.00%> (+<0.01%) ⬆️
8.4 70.74% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Contrib/Otlp/ProtobufSerializer.php 19.35% <0.00%> (+0.71%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5a5ac7...d09ca30. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

otlp+json enums should be integers

2 participants