stabilize logger.enabled#1580
Conversation
- update Logger.isEnabled signature to include context and severity number, per spec - accept event_name on a LogRecord - add event name to otlp logs payload - update or remove some comments that were based on the old logs-bridge specification
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1580 +/- ##
============================================
- Coverage 70.86% 70.79% -0.07%
- Complexity 2765 2768 +3
============================================
Files 407 407
Lines 8346 8357 +11
============================================
+ Hits 5914 5916 +2
- Misses 2432 2441 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| * emit a LogRecord, to ensure they have the most up-to-date response. | ||
| */ | ||
| public function isEnabled(): bool; | ||
| public function isEnabled(?ContextInterface $context = null, ?int $severityNumber = null): bool; |
There was a problem hiding this comment.
Changing this would break backwards compatibility; should this PR target 2.x instead?
There was a problem hiding this comment.
Since it was marked as @experimental, I think that breaking is allowable.
3 participants
Closes: #1563