A couple of code tidies left over from PR #1499#1502
Merged
brettmc merged 1 commit intoopen-telemetry:mainfrom Feb 5, 2025
Merged
A couple of code tidies left over from PR #1499#1502brettmc merged 1 commit intoopen-telemetry:mainfrom
brettmc merged 1 commit intoopen-telemetry:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1502 +/- ##
============================================
+ Coverage 70.73% 70.76% +0.02%
Complexity 2762 2762
============================================
Files 408 408
Lines 8344 8342 -2
============================================
+ Hits 5902 5903 +1
+ Misses 2442 2439 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
ChrisLightfootWild
approved these changes
Feb 5, 2025
Contributor
|
Released a new version with latest changes... |
Contributor
Author
|
Thanks :) |
| $method, | ||
| $headers, | ||
| (int) ($timeout * 1000), | ||
| (int) ($timeout * ClockInterface::MILLIS_PER_SECOND), |
Contributor
There was a problem hiding this comment.
🤦 sorry, just realised that this causes a dependency on API 1.2.1 (see here).
Contributor
There was a problem hiding this comment.
Ugh, yeah. Let's create a local const in GrpcTransportFactory for now.
Contributor
Author
|
Do you need me to do anything?
…On Fri, 7 Feb 2025, 15:45 Chris Lightfoot-Wild, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/Contrib/Grpc/GrpcTransportFactory.php
<#1502 (comment)>
:
> @@ -81,13 +82,12 @@ public function create(
$opts,
$method,
$headers,
- (int) ($timeout * 1000),
+ (int) ($timeout * ClockInterface::MILLIS_PER_SECOND),
🤦 sorry, just realised that this causes a dependency on API 1.2.1 (see
here
<https://github.com/opentelemetry-php/api/blob/1.2.1/Common/Time/ClockInterface.php#L12>
).
—
Reply to this email directly, view it on GitHub
<#1502 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABU5LCKVPBFKI4TV6FF74D2OTIIDAVCNFSM6AAAAABWRED4ZWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMBSGA4TIOJRGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a couple of style issues from #1499