adding otlp/file exporter#1465
Merged
Merged
Conversation
the spec has added in-development otlp file/stdout exporter. We already supported this programmatically, so add some factories and sdk config to allow configuration from environment (only for stdout, per spec)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1465 +/- ##
============================================
- Coverage 73.27% 73.23% -0.04%
- Complexity 2683 2686 +3
============================================
Files 387 390 +3
Lines 8014 8026 +12
============================================
+ Hits 5872 5878 +6
- Misses 2142 2148 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
ChrisLightfootWild
approved these changes
Jan 6, 2025
ChrisLightfootWild
left a comment
ChrisLightfootWild
left a comment
Contributor
There was a problem hiding this comment.
Minor linting for now or later, otherwise, looks good!
agoallikmaa
approved these changes
Jan 8, 2025
brettmc
added a commit
to brettmc/opentelemetry-php
that referenced
this pull request
Jan 9, 2025
the spec has added in-development otlp file/stdout exporter. We already supported this programmatically, so add some factories and sdk config to allow configuration from environment (only for stdout, per spec)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the spec has added in-development otlp file/stdout exporter. We already supported this programmatically, so add some factories and sdk config to allow configuration from environment (only for stdout, per spec)
See https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/file-exporter.md
Closes: #1457