Skip to content

ensure zipkin tags and attributes are cast to strings#1406

Merged
bobstrecansky merged 1 commit into
open-telemetry:mainfrom
brettmc:zipkin-strings
Oct 16, 2024
Merged

ensure zipkin tags and attributes are cast to strings#1406
bobstrecansky merged 1 commit into
open-telemetry:mainfrom
brettmc:zipkin-strings

Conversation

@brettmc

@brettmc brettmc commented Oct 16, 2024

Copy link
Copy Markdown
Contributor

Closes: #1404

@brettmc
brettmc requested a review from a team as a code owner October 16, 2024 00:22
@netlify

netlify Bot commented Oct 16, 2024

Copy link
Copy Markdown

Deploy Preview for opentelemetry-php canceled.

Name Link
🔨 Latest commit f6030dd
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-php/deploys/670f074c8ec0f30008b47d6d

@codecov

codecov Bot commented Oct 16, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.77%. Comparing base (2c1da9a) to head (f6030dd).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1406      +/-   ##
============================================
+ Coverage     73.68%   73.77%   +0.09%     
  Complexity     2682     2682              
============================================
  Files           387      387              
  Lines          7672     7672              
============================================
+ Hits           5653     5660       +7     
+ Misses         2019     2012       -7     
Flag Coverage Δ
8.1 73.41% <100.00%> (+0.01%) ⬆️
8.2 73.73% <100.00%> (+0.11%) ⬆️
8.3 73.63% <100.00%> (ø)
8.4 73.65% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Contrib/Zipkin/SpanConverter.php 97.16% <100.00%> (+0.70%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c1da9a...f6030dd. Read the comment docs.

@bobstrecansky
bobstrecansky merged commit 01d0fd3 into open-telemetry:main Oct 16, 2024
@brettmc
brettmc deleted the zipkin-strings branch January 29, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[exporter-zipkin 1.1.0] otel.dropped_attributes_count - 400: json: cannot unmarshal number into Go struct field .tags of type string

3 participants