use weaver to generate semconv#1398
Conversation
update semconv generation to use the new tooling. This is fairly close to a 1:1 of what we have now, although I noted a couple of TODOs which we might consider in future to align with what Java is doing: split attribute up into file-per-type, and split stable/unstable.
✅ Deploy Preview for opentelemetry-php canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1398 +/- ##
============================================
- Coverage 73.85% 73.80% -0.06%
Complexity 2672 2672
============================================
Files 386 386
Lines 7650 7650
============================================
- Hits 5650 5646 -4
- Misses 2000 2004 +4
Flags with carried forward coverage won't be shown. Click here to find out more. see 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| # - https://github.com/open-telemetry/semantic-conventions/releases | ||
| # - https://github.com/open-telemetry/build-tools/releases | ||
| set -e | ||
| set -ex |
There was a problem hiding this comment.
Do we want to write a trace for each command before execution? I'm assuming this is an output from shellcheck.
There was a problem hiding this comment.
It doesn't hurt, and is quite helpful for debugging. Other SIGs which I took inspiration from also have this set...
bobstrecansky
left a comment
bobstrecansky
left a comment
There was a problem hiding this comment.
One minor non-blocking nit, but the rest looks kosher. Thanks @brettmc
2 participants
update semconv generation to use the new tooling. This is fairly close to a 1:1 of what we have now, although I noted a couple of TODOs which we might consider in future to align with what Java is doing: split attribute up into file-per-type, and split stable/unstable.
The diffs are fairly small (mostly related to formatting of comments, which weaver improves). I've removed our manually-maintained deprecations, since the semconv SIG is a lot more careful now about removing stuff - that accounts for most removals.
Fixes: #1396