Skip to content

adding enum for semconv versions#1301

Merged
brettmc merged 1 commit into
open-telemetry:mainfrom
brettmc:semconv-versions
May 5, 2024
Merged

adding enum for semconv versions#1301
brettmc merged 1 commit into
open-telemetry:mainfrom
brettmc:semconv-versions

Conversation

@brettmc

@brettmc brettmc commented May 1, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented May 1, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.00%. Comparing base (100e593) to head (e3128c4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1301   +/-   ##
=========================================
  Coverage     74.00%   74.00%           
- Complexity     2367     2368    +1     
=========================================
  Files           347      348    +1     
  Lines          7077     7079    +2     
=========================================
+ Hits           5237     5239    +2     
  Misses         1840     1840           
Flag Coverage Δ
8.1 74.00% <100.00%> (+<0.01%) ⬆️
8.2 74.00% <100.00%> (+<0.01%) ⬆️
8.3 74.00% <100.00%> (+<0.01%) ⬆️
8.4 72.87% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/SemConv/Version.php 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 100e593...e3128c4. Read the comment docs.

Comment thread src/SemConv/Version.php
@brettmc
brettmc marked this pull request as ready for review May 4, 2024 05:55
@brettmc
brettmc requested a review from a team May 4, 2024 05:55
@brettmc
brettmc merged commit 8e810c6 into open-telemetry:main May 5, 2024
@brettmc
brettmc deleted the semconv-versions branch January 29, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants