Skip to content

[PHP 8.4] Fixes for implicit nullability deprecation#1297

Merged
brettmc merged 1 commit into
open-telemetry:mainfrom
skilld-labs:1296-nullable-types
Apr 29, 2024
Merged

[PHP 8.4] Fixes for implicit nullability deprecation#1297
brettmc merged 1 commit into
open-telemetry:mainfrom
skilld-labs:1296-nullable-types

Conversation

@andypost

@andypost andypost commented Apr 29, 2024

Copy link
Copy Markdown
Contributor

Fixes #1296

@andypost
andypost requested a review from a team April 29, 2024 05:02
@welcome

welcome Bot commented Apr 29, 2024

Copy link
Copy Markdown

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Apr 29, 2024 •
edited
Loading

Copy link
Copy Markdown

CLA Signed


The committers listed above are authorized under a signed CLA.

@codecov

codecov Bot commented Apr 29, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.97%. Comparing base (fc161a8) to head (ff6cc04).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1297   +/-   ##
=========================================
  Coverage     73.97%   73.97%           
  Complexity     2365     2365           
=========================================
  Files           347      347           
  Lines          7071     7071           
=========================================
  Hits           5231     5231           
  Misses         1840     1840
Flag Coverage Δ
8.1 73.97% <100.00%> (ø)
8.2 73.97% <100.00%> (ø)
8.3 73.97% <100.00%> (ø)
8.4 72.84% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/API/Baggage/Propagation/BaggagePropagator.php 96.87% <100.00%> (ø)
...c/API/Trace/Propagation/TraceContextPropagator.php 98.11% <100.00%> (ø)
src/Context/Propagation/NoopTextMapPropagator.php 88.88% <100.00%> (ø)
src/SDK/Common/Configuration/Configuration.php 96.47% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc161a8...ff6cc04. Read the comment docs.

@brettmc
brettmc merged commit f2cba82 into open-telemetry:main Apr 29, 2024
@andypost
andypost deleted the 1296-nullable-types branch April 29, 2024 05:46
@andypost andypost mentioned this pull request Sep 9, 2024
Closed
2 tasks
@andypost

andypost commented Oct 29, 2024

Copy link
Copy Markdown
Contributor Author

@brettmc please create a PHP 8.4 compatible release to unblock Drupal upgrade

@brettmc

brettmc commented Oct 30, 2024

Copy link
Copy Markdown
Contributor

Hi @andypost
PHP 8.4 doesn't go GA for a few weeks yet. What's blocking you from installing/running against drupal in the latest 8.4 RC? We run our tests against 8.4rc, and it seems to work excepting deprecations etc in some of the test tools...

@andypost

andypost commented Oct 30, 2024

Copy link
Copy Markdown
Contributor Author

@brettmc Thank you, attempted to update packages allowed to get rid of patches! Meantime bikeshedding stuck on dependency on tbachert/spi plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettmc brettmc brettmc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[PHP 8.4] Fixes for implicit nullability deprecation

2 participants

@andypost @brettmc