migrate Clock classes to API#1281
Merged
Merged
Conversation
- move Clock* + Util into API - add a deprecated wrapper for ClockFactory and Util - remove unused StopWatch* classes
brettmc
marked this pull request as ready for review
April 22, 2024 06:33
ChrisLightfootWild
approved these changes
Apr 22, 2024
ChrisLightfootWild
left a comment
ChrisLightfootWild
left a comment
Contributor
There was a problem hiding this comment.
Amazing, thanks for this! ⏱️
weslenteche
approved these changes
Apr 22, 2024
agoallikmaa
approved these changes
Apr 23, 2024
Nevay
reviewed
Apr 23, 2024
It's not really a factory, and really only provides access to a system clock. Create a Clock class which is more clear in its purpose.
per review feedback, it's only used in Zipkin. Removed some unused consts from ClockInterface
bobstrecansky
approved these changes
Apr 24, 2024
Nevay
approved these changes
Apr 26, 2024
Co-authored-by: Tobias Bachert <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1281 +/- ##
============================================
- Coverage 74.31% 73.97% -0.34%
+ Complexity 2391 2365 -26
============================================
Files 349 347 -2
Lines 7124 7071 -53
============================================
- Hits 5294 5231 -63
- Misses 1830 1840 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1280