Update SemConv to 1.25.0#1271
Conversation
|
Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one. |
5582cac to
122e672
Compare
122e672 to
b82719d
Compare
|
Sorry about the force-pushes, I had originally commited using a corporate email instead of my personal one by mistake... |
We've had issues in the past where entries have been deleted upstream, which has broken bits of our code that refer to them. semconv has been getting better in that regard, but I always check (there's some code and instructions in |
Not sure if I did it right, but both commands gave me empty outputs... I guess that means there were no removed consts, but since "it's my first time here", I'm just mentioning it to be safe... |
|
@brettmc any ETA on the release? |
Done. |
2 participants
I'm not sure if there's a workflow for this, but I noticed that there are some missing constants that (I'd like to use and) are already documented at https://opentelemetry.io/docs/specs/semconv/, so I thought I should try to help out... 🤷♂️
I only refreshed my local repo and ran
make install, updated the versions in the script, ranmake semconvand thenmake all(and all seemed fine) - don't know if that's all or if I should do something else.