Skip to content

update semconv to 1.22.0 #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brettmc merged 2 commits into from
Oct 18, 2023
Merged

update semconv to 1.22.0 #1126

brettmc merged 2 commits into from
Oct 18, 2023

Conversation

@brettmc
Copy link
Contributor

@brettmc brettmc commented Oct 13, 2023

Since 1.19.0, the source has been split out of opentelemetry-specifiction into semantic-conventions. Update the build script accordingly. Update to latest generator.
Add 2 new deprecations for semconvs which were renamed since 1.19

@brettmc
update semver to 1.22.0
cb5adc8 
Since 1.19.0, the source has been split out of opentelemetry-specifiction into semantic-conventions. Update the build script accordingly.
Update to latest generator.
Add 2 new deprecations for semconvs which were renamed since 1.19
@brettmc brettmc requested a review from a team October 13, 2023 03:01
@brettmc
Copy link
Contributor Author

brettmc commented Oct 13, 2023

Prior to merging this, I'd like to discuss whether we should tag semconv with the upstream version? i.e, publish our current version as 1.19.0 and this next one as 1.22.0.
Since the repo moved, I wasn't getting notifications of new releases, so we missed a couple. Meh.

@brettmc brettmc changed the title update semver to 1.22.0 update semconv to 1.22.0 Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023 •
edited
Loading

Codecov Report

Merging #1126 (86a363c) into main (ea86fe1) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head 86a363c differs from pull request most recent head 24bdce9. Consider uploading reports for the commit 24bdce9 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1126      +/-   ##
============================================
- Coverage     83.50%   83.49%   -0.02%     
  Complexity     2160     2160              
============================================
  Files           279      279              
  Lines          6136     6137       +1     
============================================
  Hits           5124     5124              
- Misses         1012     1013       +1
Flag Coverage Δ
7.4 82.11% <0.00%> (-0.02%) ⬇️
8.0 83.42% <0.00%> (-0.02%) ⬇️
8.1 83.55% <0.00%> (-0.02%) ⬇️
8.2 83.55% <0.00%> (-0.02%) ⬇️
8.3 83.55% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/SDK/Resource/Detectors/Sdk.php 82.35% <0.00%> (-5.15%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea86fe1...24bdce9. Read the comment docs.

@brettmc brettmc merged commit a325a8f into open-telemetry:main Oct 18, 2023
@julianocosta89 julianocosta89 mentioned this pull request Oct 19, 2023
Merged
@brettmc brettmc deleted the semver-1.22 branch January 29, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bobstrecansky bobstrecansky bobstrecansky approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brettmc @bobstrecansky